Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flatbuffer build issue. #19296

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix Flatbuffer build issue. #19296

merged 1 commit into from
Jan 31, 2024

Conversation

phoebesv
Copy link
Contributor

@phoebesv phoebesv commented Jan 28, 2024 •
edited
Loading

Description

Building on g++ 13.2.0 results in -Wstringop-overread errors on Linux. This commit addresses the flatbuffer build issue with the following changes:

  1. Remove the Werror flag in the flarbuffer patch.
  2. Add a compilation option to suppress the 'stringop-overflow' error in the Flatbuffers within the xnnpack provider.

Motivation and Context

google/flatbuffers#8119
#19239

@phoebesv
Copy link
Contributor Author

@snnn @yihonglyu, PTAL, thanks!

@snnn
Copy link
Member

snnn commented Jan 29, 2024

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, Windows ARM64 QNN CI Pipeline

@snnn
Copy link
Member

snnn commented Jan 29, 2024

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@phoebesv
Fix Flatbuffer build issue.
f72b2dd 
Building on g++ 13.2.0 results in -Wstringop-overread errors. This
commit addresses the flatbuffer build issue with the following changes:
1. Remove Werror flag in flarbuffer patch.
2. Add a compilation option to suppress the 'stringop-overflow' error in
the Flatbuffers within the xnnpack provider.

Signed-off-by: Phoebe Chen <[email protected]>
@phoebesv phoebesv requested a review from snnn January 30, 2024 02:53
@yihonglyu yihonglyu mentioned this pull request Jan 30, 2024
Merged
@snnn
Copy link
Member

snnn commented Jan 30, 2024

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, Windows ARM64 QNN CI Pipeline

@snnn
Copy link
Member

snnn commented Jan 30, 2024

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@snnn snnn merged commit 2b361c0 into microsoft:main Jan 31, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snnn snnn snnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phoebesv @snnn